GM 0.8.20080505.0 issue in Firefox 3.0 RC1 when on Yahoo Mail page

Grease Monkey context menu on Yahoo Mail page

Grease Monkey context menu on other pages (after right clicking on Yahoo Mail page)

DOM Inspector when selecting menuseperator (line above is a script entry)

This probably should be minor instead of major since GM does work, even though the context menu gets all messed up.

Could you clarify when you say "each time I right clicked" what you were right clicking on?

Replying to aranti..@gmail.com:

Could you clarify when you say "each time I right clicked" what you were right clicking on?

The Greasemonkey icon in the status bar. See the attached images.

I'll note that so far I've only seen this problem on the Yahoo Mail page (which does a lot of AJAX scripting).

Ok, I definitely don't see it on yahoo mail. Can you list all your installed extensions and user scripts?

Have you checked the error console? Does anything appear there while right-clicking the monkey?

No errors in the error console.

I managed to recreate the problem in a new profile with a single script. The problem appears to occur if the script excludes "http://*.mail.yahoo.com/*"

If I remove that exclusion GM works fine. Since the page was excluded the script should not have shown up in the list, which is probably causing the corruption issue.

I created 2 versions of a dummy script that does nothing. One excludes "http://*.mail.yahoo.com/*" and the other does not. The one that excludes Yahoo causes the problem so it has to do with the exclusion. Not sure why though. I can look into the source more.

To recreate:

1. Install the dummy_bad.user.js script and go to mail.yahoo.com (the new version, NOT the classic version). 2. Right click on the greasemonkey icon in the status bar.

To "fix":

1. Either install the dummy_good.user.js script or remove the exclusion from the script installed above.

Script which excludes Yahoo Mail (causes problem) - script does nothing

same script as above, but with no exclusion - does not cause problem

Accepting this.

Devs: Request for votes on whether this holds up the initial 0.8 release? (Removing milestone, until a positive vote.)

I found the problem. The problem is the following code in the GM_showPopup(aEvent) function in browser.js:

  // build the new list of scripts
  if (runsFramed.length) {
    runsFramed.forEach(appendScriptToPopup);
    var separator = document.createElement("menuseparator");
    separator.setAttribute("value", "hack"); // to get removed in the loop above
    popup.insertBefore(separator, tail);
  }

This is designed to add a separator to seperate the scripts that are running in frames from the ones running in the main window. The problem is that the separator is never removed after it is added so each time the user right clicks another one is created and so on and so forth.

The easiest way to fix this is to change the following code in GM_showPopup(aEvent) from

  // remove all the scripts from the list
  for (var i = popup.childNodes.length - 1; i >= 0; i--) {
    if (popup.childNodes[i].script) {
      popup.removeChild(popup.childNodes[i]);
    }
  }

to:

  // remove all the scripts from the list
  for (var i = popup.childNodes.length - 1; i >= 0; i--) {
    if ((popup.childNodes[i].script) ||
        (popup.childNodes[i].getAttribute("value") == "hack")) {
      popup.removeChild(popup.childNodes[i]);
    }
  }

This will remove the "hack" seperators when the popup is opened. Also of note, that if there are no "runsOnTop" scripts, then there will end up being 2 seperators since there are no scripts between the "hack" seperator and the bottom one.

A fix for the 2 separators would be to check to see if the runsOnTop.length > 0 before inserting the "hack" seperator.

Example change:

  // build the new list of scripts
  if (runsFramed.length) {
    runsFramed.forEach(appendScriptToPopup);
    var separator = document.createElement("menuseparator");
    separator.setAttribute("value", "hack"); // to get removed in the loop above
    popup.insertBefore(separator, tail);
  }
  runsOnTop.forEach(appendScriptToPopup);

to:

  // build the new list of scripts
  if (runsFramed.length) {
    runsFramed.forEach(appendScriptToPopup);
    if (runsOnTop.length) {
      var separator = document.createElement("menuseparator");
      separator.setAttribute("value", "hack"); // to get removed in the loop above
      popup.insertBefore(separator, tail);
    }
  }
  runsOnTop.forEach(appendScriptToPopup);

(In [744]) Fixes #111 (small variation on a patch provided by ticket poster).

Cool -- we have the plugin that catches "fixes #number" in checkin messages and updates ticket status accordingly installed. Anyway -- the patch is good; thanks!

This patch isn't in 0.8.20080609.0. Was it supposed to be?