Ticket #122 (closed defect: fixed)

Opened 4 months ago

Last modified 4 weeks ago

Interoperate with Firebug 1.2+ console object

Reported by: ecmanaut Assigned to: aranti..@gmail.com
Priority: major Milestone: 0.8.1
Version: Keywords:
Cc:

Description

In Firefox 2 with Firebug 1.05, Greasemonkey direct connects console.* to Firebug's console object. This needs redoing for Firebug 1.2, which has moved around a lot of furniture internally and externally.

Attachments

ticket#122.patch (1.8 kB) - added by mkomu..@gmail.com on 06/28/08 20:34:47.
122.patch (1.7 kB) - added by aranti..@gmail.com on 06/29/08 10:39:14.
Previous submitted patch that continues to work if Firebug is not installed
firebugConsole.patch (1.2 kB) - added by sevenfurna..@gmail.com on 08/14/08 05:50:08.
A bit tricky but should work for other methods like "dir", "time", etc
firebugConsole_rev2.patch (1.0 kB) - added by sevenfurna..@gmail.com on 08/17/08 10:15:48.
another approach that doesn't depend on eval's second argument
firebugConsole_rev3.patch (1.2 kB) - added by sevenfurna..@gmail.com on 08/29/08 04:20:31.
addressing an error "firebugContext.consoleHandler is undefined"

Change History

06/28/08 20:34:47 changed by mkomu..@gmail.com

  • attachment ticket#122.patch added.

06/29/08 10:39:14 changed by aranti..@gmail.com

  • attachment 122.patch added.

Previous submitted patch that continues to work if Firebug is not installed

06/29/08 10:40:08 changed by aranti..@gmail.com

  • owner set to aranti..@gmail.com.
  • status changed from new to assigned.
  • milestone set to 0.8.1.

I've tested the submitted patch and saw just one change needed: testing for when TabWatcher? is not present, because Firebug is not. I've attached the patch that includes that. Looking for at least one more vote to commit to trunk, please.

07/03/08 18:57:10 changed by aranti..@gmail.com

To do: also check what happens in the Firebug-is-installed but console-is-disabled case.

07/04/08 12:27:22 changed by aranti..@gmail.com

(In [750]) Refs #122

  • Incorporate the suggested patch to restore Firebug 1.2 console compatibility.

07/04/08 12:58:37 changed by aranti..@gmail.com

(In [751]) Refs #122

  • For Firebug 1.2 case, check that the console is enabled, before logging to it.

07/22/08 18:53:24 changed by willia..@skellenger.net

console.dir() will not/does not work with this patch...

Looks like the only console commands suppoarted are:

var commands = ["log", "debug", "info", "warn", "error"];

With Firefox2, I think any console command was supported...?

08/14/08 05:50:08 changed by sevenfurna..@gmail.com

  • attachment firebugConsole.patch added.

A bit tricky but should work for other methods like "dir", "time", etc

08/14/08 16:07:01 changed by oyasu..@gmail.com

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [752]) Optimization to straight code for the subscript loader, as suggested by Anthony. Applying a patch by sevenfurna..@gmail.com that fixes #122 -- thanks!

08/17/08 10:15:48 changed by sevenfurna..@gmail.com

  • attachment firebugConsole_rev2.patch added.

another approach that doesn't depend on eval's second argument

08/29/08 04:20:31 changed by sevenfurna..@gmail.com

  • attachment firebugConsole_rev3.patch added.

addressing an error "firebugContext.consoleHandler is undefined"

(follow-up: ↓ 8 ) 08/29/08 20:30:41 changed by v..@omertabeyond.com

Using latest svn build of GM and 1.3 svn of firebug no script is being able to properly function.

This is the message i'm getting in firebug console ->

FirebugConsoleHandler? is not defined .../Profiles/e2tcsw7b.default/extensions/%7Be4a8a97b-f2ed-450b-b12d-ee082ba24781%7D/components/greasemonkey.js Line 403

(in reply to: ↑ 7 ) 09/04/08 13:47:56 changed by v..@omertabeyond.com

using firebugConsole_rev3.patch got fixed the issue.

Replying to v..@omertabeyond.com:

Using latest svn build of GM and 1.3 svn of firebug no script is being able to properly function. This is the message i'm getting in firebug console -> FirebugConsoleHandler? is not defined .../Profiles/e2tcsw7b.default/extensions/%7Be4a8a97b-f2ed-450b-b12d-ee082ba24781%7D/components/greasemonkey.js Line 403

09/11/08 09:29:48 changed by oyasu..@gmail.com

(In [753]) Applying another patch by sevenfurna..@gmail.com that fixes #122 again, without eval and in Firefox 3.0.2 onward -- thanks!

Add/Change #122 (Interoperate with Firebug 1.2+ console object)




Action