Cannot install same userscript for multiple users. (Linux)

Probably obvious, but a better approach would be to write these files in a way that they are overwritable. That way no need to worry about cases where the removal doesn't happen.

Even better is to use the PID in the temporary file name. Since no two processes will have the same PID, this prevents two instances of Greasemonkey from even attempting to use the same filename for temporary files. This way there's no need to play with permissions either.

On most systems, files in /tmp will be cleaned up after some time, but I think programs should attempt to clean up after themselves anyway.

Furniture Ashley Furniture Store

Identical problem in Fedora 8.

This isn't a minor problem. It's a major problem with security implications. GreaseMonkey? should be using nsIFile.createUnique() rather than cooking its own temporary files.

partial fix for tmpefile issues

I just attached this patch but unfortunately trac seems to have mangled it (a hunk is missing), so here it is pasted. This patch fixes the installation issues but doesn't fix the alternate path of viewing the source (I wasn't sure how to handle that).

Additionally this patch fixes the stream.init() call to use octal for permissions. The original value 420 was interpreted as decimal. The 0664 will be ANDed to the umask to create the file with appropriate permissions.

--- config.js~	2008-04-16 09:16:03.000000000 -0400
+++ config.js	2008-04-16 09:16:10.000000000 -040..@@ -151,7 +151,7 @@
 
     try {
       this.initFilename(script);
-      script.file.copyTo(newDir, script.filename)
+      script.file.moveTo(newDir, script.filename);
       this.scripts.push(script);
       this.save();
     }

--- scriptdownloader.js~	2008-01-21 11:02:00.000000000 -0500
+++ scriptdownloader.js	2008-04-16 09:17:27.000000000 -040..@@ -52,6 +52,7 @@
 
   var base = this.script.name.replace(/[^A-Z0-9_]/gi, "").toLowerCase();
   file.append(base + ".user.js");
+  file.createUnique(Components.interfaces.nsIFile.NORMAL_FILE_TYPE, 0664); // honors umask
 
   var converter =  
     Components.classes..@mozilla.org/intl/scriptableunicodeconverter"]  

--- utils.js~	2008-01-21 11:02:00.000000000 -0500
+++ utils.js	2008-04-16 09:07:09.000000000 -040..@@ -199,7 +199,8 @@
   var stream = Components.classes..@mozilla.org/network/file-output-stream;1"]
     .createInstance(Components.interfaces.nsIFileOutputStream);
 
-  stream.init(file, 0x02 | 0x08 | 0x20, 420, -1);
+  // PR_WRONLY | PR_CREATE_FILE | PR_TRUNCATE
+  stream.init(file, 0x02 | 0x08 | 0x20, 0664, -1); // honors umask
 
   return stream;
 }

The attached patch file is fine. But it appears to be against the 0.7 release, rather than trunk. The copyTo line does not exist, and I fail to see the point of changing the stream.init line.

Suggested patch to ensure unique files when downloading initial script.

(In [735]) Fixes #37 Fixes #89

• When creating temporary files, always use nsILocalFile.createUnique()
• Track temporary files created during script install
• Clean up all temporary files when script install completes or is canceled

Драма книги для телефона