Ticket #79 (closed defect: fixed)

Opened 11 months ago

Last modified 5 months ago

openInEditor not working on OS X

Reported by: boo..@youngpup.net Assigned to:
Priority: major Milestone: 0.8
Version: Keywords:
Cc:

Description

When I use any functionality that requires openInEditor on OS X it fails silently. This was recently changed, so it probably regressed there.

Attachments

Change History

12/30/07 15:06:26 changed by thalam..@hotmail.com

Duplicate (sortof) and related to Ticket #59

Anyone going to buy me a Mac so I can test this stuff? ;D *Grin*

(follow-up: ↓ 3 ) 01/01/08 14:51:39 changed by boo..@youngpup.net

I looked into this and it is happening essentially because application bundles are not executable programs.

But as a test, I tried setting my editor to, eg, /Applications/TextEdit.app/Contents/MacOS/TestEdit instead of just /Applications/TextEdit.app and it still didn't work.

I guess we went too low in the abstractions here (trying to use nsIProcess directly) and need to use Firefox's high-level stuff after all (or else rewrite the logic to figure out how to run a given application, which seems very complex).

I retested whether the current released Greasemonkey (0.7...) has this problem and it doesn't. It works correctly on FF2 and the current FF3 alpha.

So it looks like we need to retrace our steps. Either:

a) The original cause of #59 was a temporary regression in the FF alpha I had at that time that has since gone away (solution: roll back to original implementation of openInEditor()), or:

b) The problem still exists, but only in Windows FF alpha (solution: find a solution to that problem that uses the APIs we were originally using), or:

c) The code for openInEditor() changed at some point between the current 0.7 release and when #59 was reported. (solution: figure out what the regression was and fix).

(in reply to: ↑ 2 ) 01/01/08 18:55:14 changed by boo..@youngpup.net

Replying to boo..@youngpup.net:

b) The problem still exists, but only in Windows FF alpha (solution: find a solution to that problem that uses the APIs we were originally using), or:

It turned out to be this one. openInEditor does not work on Greasemonkey 0.7 from a.m.o with FF3 on Windows, but it *does* work on OS X.

So it seems like the right solution is to go back to the drawing board with solutions to #59, probably one that uses nsIMimeService. If not that, more closely do whatever nsIMimeService does, directly.

01/05/08 17:44:49 changed by boo..@youngpup.net

New trial fix in changeset [591]. Needs testing on mac and internationalization for new messages.

01/18/08 23:26:16 changed by boo..@youngpup.net

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in changeset [607]

(follow-up: ↓ 7 ) 04/26/08 23:26:47 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

This does not seem to be fixed with the current build of Greasemonkey.

(in reply to: ↑ 6 ) 04/29/08 06:44:09 changed by aranti..@gmail.com

  • status changed from reopened to closed.
  • resolution set to fixed.

Replying to anonymous:

This does not seem to be fixed with the current build of Greasemonkey.

I believe you are wrong, I've tested this myself. What are you calling "the current build"?

06/22/08 22:57:03 changed by 341 meeting

Nice Site! http://google.com

06/27/08 21:22:54 changed by orchard bank

Nice Site! http://google.com

06/30/08 07:55:47 changed by prepaid cards

Nice Site! http://google.com

Add/Change #79 (openInEditor not working on OS X)




Action