Ticket #90 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

Script Install Dialog: Theme incompatibility

Reported by: aranti..@gmail.com Assigned to:
Priority: major Milestone:
Version: Keywords:
Cc: RealityRipple@gmail.com

Description

Originally reported at: http://groups.google.com/group/greasemonkey-users/t/1fac9dc8c8d78351

When using my theme, In The Dark (https://addons.mozilla.org/en-US/firefox/addon/6284 ), the Script installer doesn't follow the coloring correctly. It ends up looking like this: http://realityripple.com/Uploads/Grease.jpg . Could you possibly make your extension's installer use the mozapps \xpiinstall\xpinstallConfirm.css file instead of hardcoding it?

Attachments

Grease.jpg (22.7 kB) - added by aranti..@gmail.com on 03/18/08 07:00:15.
ticket#90.patch (0.7 kB) - added by loucypher.m..@gmail.com on 03/19/08 09:14:46.
Patch

Change History

03/18/08 07:00:15 changed by aranti..@gmail.com

  • attachment Grease.jpg added.

03/19/08 09:14:46 changed by loucypher.m..@gmail.com

  • attachment ticket#90.patch added.

Patch

03/19/08 10:17:01 changed by aranti..@gmail.com

  • cc set to RealityRipp..@gmail.com.

I don't really know what the original reporter was looking for; so I'm adding him (?) to the CC list. Can you please provide some input, does this change help?

03/19/08 10:59:18 changed by RealityRipp..@gmail.com

That does make the text legible, but it still doesn't use the colors defined in the user's theme. If theme integration isn't a goal, that works fine.

04/12/08 07:31:18 changed by aranti..@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

(In [725]) Fixes #90

It's unclear to me what exactly the reporter really wants here, though this is an improvement. Given further details (especially a patch), we may go further.

04/12/08 10:34:43 changed by RealityRipp..@GMail.com

All I want is for text to show up correctly. However, if the creator wishes to include better theme integration into this extension, using chrome://mozapps/skin/xpinstall/xpinstallConfirm.css instead of custom style values would be recommended.

Add/Change #90 (Script Install Dialog: Theme incompatibility)




Action