Ticket #93 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Edit button doesn't work with FF3

Reported by: ghodmo..@ghodmode.com Assigned to: aranti..@gmail.com
Priority: major Milestone: 0.8
Version: Keywords:
Cc:

Description

When I highlight a script and click the Edit button, nothing seems to happen. I'm using Firefox 3.0b4 and Greasemonkey 0.7.20080121.0.

I've tried different values for greasemonkey.editor in about:config and, while troubleshooting, I ended up with a shell script that records it's command line and output to a text file for me to look at. The script is never executed.

I tried a few variations of using strace -p <firefox-bin pid> 2>&1 | grep <my editor> while clicking on the Edit button and I learned a couple of things:

Even if the editor isn't set to gvim, it always looks for and opens gvim.desktop, in ~/.local/share/applications, /usr/local/share/applications, and finally in /usr/share/applications. I suppose it would stop at my home directory if it found it there.

It does try to access (ref: http://linux.die.net/man/2/access) the program, checking modes of F_OK and X_OK. A guess would be that it's looking for the file and making sure it can run it, but someone forgot to put in the line of code that actually calls the editor.

Attachments

Change History

04/01/08 04:13:20 changed by anonymous

I get the exact same problem

(follow-up: ↓ 3 ) 04/01/08 12:17:46 changed by loucypher.m..@gmail.com

WFM on WinXP

Try to reset the preference instead of changing the value by right clicking on "greasemonkey.editor" and select "Reset". Open Script Manager again, select a script, and click the "Edit" button. You will then be prompted to choose a text editor.

(in reply to: ↑ 2 ) 04/02/08 01:24:42 changed by ghodmo..@ghodmode.com

Replying to loucypher.m..@gmail.com:

WFM on WinXP Try to reset the preference instead of changing the value by right clicking on "greasemonkey.editor" and select "Reset". Open Script Manager again, select a script, and click the "Edit" button. You will then be prompted to choose a text editor.

Thank you. I tried this, but there's no change.

04/02/08 02:58:19 changed by anonymous

just 2 hours for useless shit. Have you ever heard that sw you provide (open or not) must have some addable value for user.

04/03/08 20:31:50 changed by aranti..@gmail.com

  • owner set to aranti..@gmail.com.
  • status changed from new to assigned.
  • milestone set to 0.8.

Confirmed with Ubuntu 7.10. Accepting.

04/04/08 18:52:02 changed by aranti..@gmail.com

  • summary changed from Edit button doesn't work with FF3 to ::.

Also confirmed on Mac OSX. Exact error:

Could not launch editor. [Exception... "Could not convert JavaScript argument arg 0 [nsIMIMEInfo.preferredApplicationHandler]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location JS frame :: chrome://greasemonkey/content/utils.js :: launchApplicationWithDoc :: line 189" data: no]

04/04/08 18:52:34 changed by aranti..@gmail.com

  • summary changed from :: to Edit button doesn't work with FF3.

Whoops, typo!

04/04/08 19:25:30 changed by aranti..@gmail.com

See: https://bugzilla.mozilla.org/show_bug.cgi?id=411819

The nsIProcess hack seems to work on Linux. As described, it does not work on Mac.

04/04/08 20:21:39 changed by aranti..@gmail.com

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [715]) Fixes #93

04/15/08 21:36:09 changed by tr..@trevorcreech.com

Confirming that this is fixed in the latest build. FF3b5 on Ubuntu 8.04 beta.


Add/Change #93 (Edit button doesn't work with FF3)




Action