Ticket #97 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

"Install" button on install banner has non-localizeable access key "I"

Reported by: tim.baby..@gmail.com Assigned to:
Priority: trivial Milestone:
Version: Keywords:
Cc:

Description

That looks bad in localized builds.

See source:trunk/src/chrome/chromeFiles/content/browser.js lines 179 and 200.

Attachments

Екран-6.png (3.9 kB) - added by tim.baby..@gmail.com on 04/05/08 14:25:48.

Change History

04/05/08 14:25:48 changed by tim.baby..@gmail.com

  • attachment Екран-6.png added.

04/06/08 11:06:41 changed by aranti..@gmail.com

Same for the main greasemonkey menu. See line 43:

browser:trunk/src/chrome/chromeFiles/content/browser.xul

04/06/08 12:25:08 changed by tim.baby..@gmail.com

Well, in browser.xul both label and accesskey are unlocalizeable, that makes sence. Unlike the issue mentioned, see screenshot.

04/12/08 07:20:10 changed by aranti..@gmail.com

(In [724]) Refs #97

  • Create 'greeting.btnAccess' key in gm-browser.properties
  • Use it in GM_BrowserUI.showInstallBanner()

04/12/08 07:28:37 changed by aranti..@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

I've realized that the menu mentioned is just "Greasemonkey" which isn't really localizable, being the name of the extension.

Add/Change #97 ("Install" button on install banner has non-localizeable access key "I")




Action