Ticket #98 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Entire gm_scripts directory removed on script uninstall, after upgrade

Reported by: aranti..@gmail.com Assigned to: aranti..@gmail.com
Priority: major Milestone: 0.8
Version: Keywords:
Cc:

Description

Steps to reproduce:

  1. Blank profile
  2. Install GM 0.7
  3. Install linkify.user.js
  4. Install checkrange.user.js
  5. Install sourceplease.user.js
  6. Install GM 0.8
  7. In GM manage dialog, uninstall any script
  8. The entire gm_scripts directory is completely removed.

This actually happens with only one installed script, but the multiples makes it more obvious that it's all wiped out.

Attachments

Change History

04/08/08 16:44:37 changed by aranti..@gmail.com

At line 293 of config.js I see an "equals" check of two variables, script._baseDirFile is "c:\gmdev\gm_scripts\." whereas this._scriptDir is "c:\gmdev\gm_scripts" and equals() compares to false. This triggers the "script has own directory" code which removes the script basedir .. which happens to be the main gm_scripts dir.

04/08/08 17:06:05 changed by aranti..@gmail.com

  • status changed from new to closed.
  • resolution set to fixed.

(In [721]) Fixes #98

  • Normalize the path to the script directory.

Add/Change #98 (Entire gm_scripts directory removed on script uninstall, after upgrade)




Action